feat: add synchronous gauge #1718
Conversation
xuan-cao-swi
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd and
kaylareopelle
as code owners
There was a problem hiding this comment.
Thanks for opening this, Xuan! Even more reason to get #1604 merged.
Co-authored-by: Kayla Reopelle <87386821+kaylareopelle@users.noreply.github.com>
Co-authored-by: Kayla Reopelle <87386821+kaylareopelle@users.noreply.github.com>
Co-authored-by: Kayla Reopelle <87386821+kaylareopelle@users.noreply.github.com>
Co-authored-by: Kayla Reopelle <87386821+kaylareopelle@users.noreply.github.com>
Co-authored-by: Kayla Reopelle <87386821+kaylareopelle@users.noreply.github.com>
Co-authored-by: Kayla Reopelle <87386821+kaylareopelle@users.noreply.github.com>
Co-authored-by: Kayla Reopelle <87386821+kaylareopelle@users.noreply.github.com>
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
…uby into issues-1704
|
I'd like to make my interest in this known. I'm in the process of moving all my production applications from Datadog to self-hosted Signoz, which rely on OTel providers. We currently have multiple areas where we report current state of things (such as background queue size and latency) via gauge metrics. Without this Gauge metric, I'm not able to complete the migration. So would be very keen to see this completed in a future release. |
|
Updated the aggregation to last value. Updated the test case. |
| _(last_snapshot[0].data_points[0].value).must_equal(1) | ||
| end | ||
|
|
||
| it 'gauge should count 1 for last recording' do |
There was a problem hiding this comment.
Maybe this needs a different title for the assertion? It seems like the goal here is to make sure two different gauges can be evaluated individually?
|
|
||
| private | ||
|
|
||
| # TODO: replace the default aggregation to LastValue |
There was a problem hiding this comment.
| # TODO: replace the default aggregation to LastValue |
| # TODO: When the metrics SDK stabilizes and is merged into the main SDK, | ||
| # we can leverage the SDK Internal validation classes to enforce this: | ||
| # https://github.com/open-telemetry/opentelemetry-ruby/blob/6bec625ef49004f364457c26263df421526b60d6/sdk/lib/opentelemetry/sdk/internal.rb#L47 |
There was a problem hiding this comment.
Could we turn this TODO into an issue, or reference it on an existing issue?
Description:
Add simple gauge metrics that only record last value of recording.
Closes #1704
TODO: