Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to library config #1081

Merged
merged 3 commits into from
Jan 27, 2022
Merged

Fix link to library config #1081

merged 3 commits into from
Jan 27, 2022

Conversation

cartermp
Copy link
Contributor

@cartermp cartermp commented Jan 7, 2022

This fix ensures we can update the docs on the website. relref links are necessary for most links, which I missed in my first pass here!

This fix ensures we can update the docs on the website. `relref` links are necessary for most links, which I missed in my first pass here!
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than:

[configure-specific-libraries]({{< relref "configuring_automatic_instrumentation#configuring-specific-instrumentation-libraries" >}})

I think that you meant to write:

[configure-specific-libraries]: {{< relref "configuring_automatic_instrumentation#configuring-specific-instrumentation-libraries" >}}

@chalin
Copy link
Contributor

chalin commented Jan 22, 2022

(I'd have made the edit myself, but don't have the permissions.)

@arielvalentin
Copy link
Contributor

Thanks @chalin!

@cartermp would you kindly apply their suggestion?

@cartermp
Copy link
Contributor Author

Weird, what I had allowed me to build the site locally - but this is more uniform w.r.t the other links

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin
Copy link
Contributor

chalin commented Jan 27, 2022

Hi all: can we get this merged soon?

Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwear mwear merged commit 3de5cb5 into open-telemetry:main Jan 27, 2022
@cartermp cartermp deleted the patch-1 branch January 27, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants