Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db.instance.id Semantic Convention #745

Closed
arielvalentin opened this issue Nov 30, 2023 · 2 comments · Fixed by #758
Closed

db.instance.id Semantic Convention #745

arielvalentin opened this issue Nov 30, 2023 · 2 comments · Fixed by #758
Labels
good first issue Good for newcomers help wanted Extra attention is needed instrumentation

Comments

@arielvalentin
Copy link
Collaborator

db.instance.id replaces the custom db.mysql.instance.address attribute as of merging the following PR:

open-telemetry/semantic-conventions#345

This attribute is currently used by the Trilogy instrumentation.

@arielvalentin arielvalentin added good first issue Good for newcomers help wanted Extra attention is needed instrumentation labels Nov 30, 2023
@dlahn
Copy link
Contributor

dlahn commented Dec 7, 2023

@arielvalentin
Copy link
Collaborator Author

arielvalentin commented Dec 7, 2023

@dlahn we have had a few discussions about the continued use of the Semantic Conventions gem and I think we have all but decided to abandon its use in its current form.

We do not have an easy way right now to do things like Schema Versions nor do we emit schema URLs as part of the instrumentation scope, so you cannot really tell what version of the semconv schema an instrumentation is using.

In addition to that the gem itself does not support multiple schema versions or alternative pre-1.0 semconv compatibility envars.

For now we are moving forward with the use of string literals.

If this is an area where you would like to help us, we welcome your contributions!

cc: @robbkidd

dlahn added a commit to dlahn/opentelemetry-ruby-contrib that referenced this issue Dec 7, 2023
dlahn added a commit to dlahn/opentelemetry-ruby-contrib that referenced this issue Dec 8, 2023
arielvalentin added a commit that referenced this issue Dec 8, 2023
* refactor(trilogy): change db.mysql.instance.address to db.instance.id

fixes #745

* feat!(trilogy): change db.mysql.instance.address to db.instance.id

fixes #745

---------

Co-authored-by: Ariel Valentin <arielvalentin@users.noreply.github.com>
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed instrumentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants