Skip to content

Commit

Permalink
chore: Add ruby version conditions
Browse files Browse the repository at this point in the history
Rails 7.2.0 requires Ruby 3.1. We test on Ruby 3.0.
Prevent running the 7.2 tests on that version.
  • Loading branch information
kaylareopelle committed Aug 12, 2024
1 parent 135149a commit 30457ce
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 12 deletions.
6 changes: 4 additions & 2 deletions instrumentation/action_mailer/Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ appraise 'rails-7.1' do
gem 'rails', '~> 7.1.0'
end

appraise 'rails-7.2' do
gem 'rails', '~> 7.2.0'
if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.1.0')
appraise 'rails-7.2' do
gem 'rails', '~> 7.2.0'
end
end
6 changes: 4 additions & 2 deletions instrumentation/action_pack/Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ appraise 'rails-7.1' do
gem 'rails', '~> 7.1.0'
end

appraise 'rails-7.2' do
gem 'rails', '~> 7.2.0'
if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.1.0')
appraise 'rails-7.2' do
gem 'rails', '~> 7.2.0'
end
end
6 changes: 4 additions & 2 deletions instrumentation/action_view/Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ appraise 'rails-7.1' do
gem 'rails', '~> 7.1.0'
end

appraise 'rails-7.2' do
gem 'rails', '~> 7.2.0'
if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.1.0')
appraise 'rails-7.2' do
gem 'rails', '~> 7.2.0'
end
end
6 changes: 4 additions & 2 deletions instrumentation/active_record/Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ appraise 'activerecord-7.1' do
gem 'activerecord', '~> 7.1.0'
end

appraise 'activerecord-7.2' do
gem 'activerecord', '~> 7.2.0'
if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.1.0')
appraise 'activerecord-7.2' do
gem 'activerecord', '~> 7.2.0'
end
end
6 changes: 4 additions & 2 deletions instrumentation/active_support/Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ appraise 'activesupport-7.1' do
gem 'activesupport', '~> 7.1.0'
end

appraise 'activesupport-7.2' do
gem 'activesupport', '~> 7.2.0'
if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.1.0')
appraise 'activesupport-7.2' do
gem 'activesupport', '~> 7.2.0'
end
end
6 changes: 4 additions & 2 deletions instrumentation/rails/Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ appraise 'rails-7.1' do
gem 'rails', '~> 7.1.0'
end

appraise 'rails-7.2' do
gem 'rails', '~> 7.2.0'
if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.1.0')
appraise 'rails-7.2' do
gem 'rails', '~> 7.2.0'
end
end

0 comments on commit 30457ce

Please sign in to comment.