-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move duplicated code to a dependency #942
Conversation
Fixes issue_762
@@ -43,6 +43,7 @@ install_requires = | |||
botocore ~= 1.0 | |||
opentelemetry-api == 0.11.dev0 | |||
opentelemetry-instrumentation == 0.11.dev0 | |||
opentelemetry-ext-boto == 0.11.dev0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too familiar with boto or botocore. Should the dependency be the other way around? Is botocore the more lower-level
integration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, happy to merge once @lzchen's comment has been addressed
This reverts commit c38d9d8.
Comment has been addressed. |
Fixes #762