-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure status is always string #640
Merged
toumorokoshi
merged 13 commits into
open-telemetry:master
from
codeboten:collector-exporter-status
May 15, 2020
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5e83d56
fix: ensure status is always string
c43a31d
fix test
8310a5d
log a warning if an invalid description is used
e6faa08
Merge remote-tracking branch 'origin/master' into collector-exporter-…
1bb637c
no more need to check instance type
fb3aea2
Apply suggestions from code review
1823d62
add test for logged warning
d46ac1f
fix mypy
85e1bc8
Merge branch 'master' into collector-exporter-status
c7f8d7c
Apply suggestions from code review
f3e5aa0
Merge branch 'master' into collector-exporter-status
fe66e2a
fix tests
552db62
Merge branch 'master' into collector-exporter-status
toumorokoshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# Copyright The OpenTelemetry Authors | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import unittest | ||
from logging import WARNING | ||
|
||
from opentelemetry.trace.status import Status, StatusCanonicalCode | ||
|
||
|
||
class TestStatus(unittest.TestCase): | ||
def test_constructor(self): | ||
status = Status() | ||
self.assertEqual(status.canonical_code, StatusCanonicalCode.OK) | ||
codeboten marked this conversation as resolved.
Show resolved
Hide resolved
|
||
self.assertIsNone(status.description) | ||
|
||
status = Status(StatusCanonicalCode.UNAVAILABLE, "unavailable") | ||
self.assertEqual( | ||
codeboten marked this conversation as resolved.
Show resolved
Hide resolved
|
||
status.canonical_code, StatusCanonicalCode.UNAVAILABLE | ||
) | ||
self.assertEqual(status.description, "unavailable") | ||
|
||
def test_invalid_description(self): | ||
with self.assertLogs(level=WARNING): | ||
status = Status(description={"test": "val"}) # type: ignore | ||
self.assertEqual(status.canonical_code, StatusCanonicalCode.OK) | ||
codeboten marked this conversation as resolved.
Show resolved
Hide resolved
|
||
self.assertEqual(status.description, "") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this particular test should not be included here as it's testing something implemented in a different place.