Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updating readme #639

Merged
merged 4 commits into from
May 5, 2020
Merged

docs: updating readme #639

merged 4 commits into from
May 5, 2020

Conversation

codeboten
Copy link
Contributor

This is making the readme consistent with some of the other SIG repos:

@codeboten codeboten requested a review from a team May 3, 2020 03:52
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Copy link
Member

@mauriciovasquezbernal mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice.
Just one comment about the link to the examples.

README.md Outdated
<strong>
<a href="CONTRIBUTING.md">Contributing<a/>
&nbsp;&nbsp;&bull;&nbsp;&nbsp;
<a href="docs/examples/">Examples<a/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codeboten want to apply this fix and we'll merge after?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mauriciovasquezbernal! applied your suggestion.

README.md Outdated Show resolved Hide resolved
@toumorokoshi toumorokoshi merged commit 48ad6ad into master May 5, 2020
@codeboten codeboten deleted the codeboten/update-readme branch May 11, 2020 22:03
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
* chore: 0.3.1 release proposal

* chore: npm run bootstrap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants