opentelemetry-exporter-otlp-proto-http: refactor to use shared opentelemetry-exporter-otlp-common and opentelemetry-exporter-http-transport packages by herin049 · Pull Request #5389 · open-telemetry/opentelemetry-python

herin049 · 2026-07-04T03:36:36Z

Description

Refactors the opentelemetry-exporter-otlp-proto-http package to use the new shared opentelemetry-exporter-otlp-common and opentelemetry-exporter-http-transport packages packages.

Fixes #2990

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Tox

Does This PR Require a Contrib Repo Change?

Yes. - Link to PR:
No.

Checklist:

Followed the style guidelines of this project
Changelogs have been updated
Unit tests have been added
Documentation has been updated

…lemetry-exporter-otlp-common and opentelemetry-exporter-http-transport packages

Copilot

Pull request overview

Refactors opentelemetry-exporter-otlp-proto-http to delegate HTTP transport, retry/backoff, compression, and configuration resolution to the shared opentelemetry-exporter-otlp-common and opentelemetry-exporter-http-transport packages, and updates tests/build wiring accordingly.

Changes:

Replaces per-exporter HTTP/retry/compression logic with shared opentelemetry.exporter.otlp.common._http.OTLPHTTPClient and new helpers in proto.http._common.
Updates opentelemetry-exporter-otlp-proto-http dependencies/extras so requests is optional (via an extra) while default transport uses urllib3.
Reworks unit/functional tests to validate behavior via transport-level request interception and deterministic retry timing.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
uv.lock	Adds locked workspace deps for `opentelemetry-exporter-otlp-common` and `opentelemetry-exporter-http-transport`; moves `requests` behind an extra.
tox.ini	Ensures tox envs install the new shared exporter packages.
tests/opentelemetry-docker-tests/tests/otlpexporter/test_otlp_http_exporter_functional.py	Updates functional test helper to hook the new `_export_batch` path.
pyproject.toml	Adds `opentelemetry-exporter-otlp-common` to workspace dependencies.
exporter/opentelemetry-exporter-otlp/test-requirements.txt	Adds editable installs for new shared packages + transport extras for OTLP exporter tests.
exporter/opentelemetry-exporter-otlp-proto-http/tests/test_proto_span_exporter.py	Rewrites span exporter tests for shared transport/client behavior (mocket-based).
exporter/opentelemetry-exporter-otlp-proto-http/tests/test_proto_log_exporter.py	Rewrites log exporter tests for shared transport/client behavior (mocket-based).
exporter/opentelemetry-exporter-otlp-proto-http/tests/metrics/test_otlp_metrics_exporter.py	Updates metrics exporter tests for shared transport/client behavior and batch splitting.
exporter/opentelemetry-exporter-otlp-proto-http/tests/test_common.py	Adds targeted unit tests for new `_common` resolution/build helpers.
exporter/opentelemetry-exporter-otlp-proto-http/tests/init.py	Adds a shared `_mock_clock` helper for deterministic retry/backoff testing.
exporter/opentelemetry-exporter-otlp-proto-http/test-requirements.txt	Adds `mocket` and new editable workspace dependencies for this package’s tests.
exporter/opentelemetry-exporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/trace_exporter/init.py	Switches span exporter implementation to shared OTLP HTTP client + common config helpers.
exporter/opentelemetry-exporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/metric_exporter/init.py	Switches metrics exporter implementation to shared OTLP HTTP client + common config helpers.
exporter/opentelemetry-exporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/_log_exporter/init.py	Switches log exporter implementation to shared OTLP HTTP client + common config helpers.
exporter/opentelemetry-exporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/_common/init.py	Adds shared endpoint/header/timeout/compression resolution and transport construction helpers.
exporter/opentelemetry-exporter-otlp-proto-http/pyproject.toml	Replaces hard dependency on `requests` with shared packages; adds `requests` extra.
docs/conf.py	Updates intersphinx + nitpick ignores for new types referenced in docs.
docs-requirements.txt	Installs `opentelemetry-exporter-otlp-proto-http[requests]` for doc builds.
.changelog/5389.changed	Adds changelog entry for the refactor.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

The gRPC exporters parse their timeout environment variables with a bare float(), so a value like OTEL_EXPORTER_OTLP_TIMEOUT=10s raises ValueError during exporter construction and takes down SDK startup. Add a shared _timeout_from_env() helper in opentelemetry-exporter-otlp- proto-common that warns and falls back instead, matching how the repo already handles invalid temporality and export-interval values, and use it from the gRPC mixin and the three signal exporters. Precedence between the signal-specific and generic variables is unchanged. Also fix `timeout or ...` silently discarding an explicit timeout=0; it is now `timeout is not None`. The HTTP exporters got the same treatment in open-telemetry#5389, so this change is limited to the gRPC exporters.

…o-http 1.45 opentelemetry-exporter-otlp-proto-http 1.45.0 moved the exporter's headers onto its internal HTTP client (open-telemetry/opentelemetry-python#5389), so reading HTTPSpanExporter._headers raised AttributeError whenever register() built the tracing details with the HTTP transport. Read the headers from the exporter's client when the exporter has none, and leave out the headers the exporter adds on its own so the tracing details show the same headers as before.

…o-http 1.45 (#16549) * fix(otel): fix register() crash with opentelemetry-exporter-otlp-proto-http 1.45 opentelemetry-exporter-otlp-proto-http 1.45.0 moved the exporter's headers onto its internal HTTP client (open-telemetry/opentelemetry-python#5389), so reading HTTPSpanExporter._headers raised AttributeError whenever register() built the tracing details with the HTTP transport. Read the headers from the exporter's client when the exporter has none, and leave out the headers the exporter adds on its own so the tracing details show the same headers as before. * fix(otel): require opentelemetry-exporter-otlp-proto-http>=1.45 and read headers from the client The compat branch that read HTTPSpanExporter._headers on older versions is gone; phoenix-otel now requires the exporter release that moved headers onto the internal HTTP client, and _exporter_headers reads them from there. The root dev pins move to 1.45.0/0.66b0 so the workspace lockfile resolves. opentelemetry-api 1.45 defines AttributeValue by chained assignment, which mypy does not accept as a type alias, so phoenix.trace.attributes now carries an equivalent alias and the server imports it from there. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Alexander Song <axiomofjoy@gmail.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

Only the gRPC exporters use it now that the HTTP side landed in open-telemetry#5389. It lives in the package __init__ rather than exporter.py because the logger there has a DuplicateFilter keyed on the message template, which would drop the warning for a second invalid variable.

…vars (open-telemetry#5448) * Fall back to the default when an OTLP gRPC timeout env var is invalid The gRPC exporters parse their timeout environment variables with a bare float(), so a value like OTEL_EXPORTER_OTLP_TIMEOUT=10s raises ValueError during exporter construction and takes down SDK startup. Add a shared _timeout_from_env() helper in opentelemetry-exporter-otlp- proto-common that warns and falls back instead, matching how the repo already handles invalid temporality and export-interval values, and use it from the gRPC mixin and the three signal exporters. Precedence between the signal-specific and generic variables is unchanged. Also fix `timeout or ...` silently discarding an explicit timeout=0; it is now `timeout is not None`. The HTTP exporters got the same treatment in open-telemetry#5389, so this change is limited to the gRPC exporters. * Move _timeout_from_env into the gRPC exporter package Only the gRPC exporters use it now that the HTTP side landed in open-telemetry#5389. It lives in the package __init__ rather than exporter.py because the logger there has a DuplicateFilter keyed on the message template, which would drop the warning for a second invalid variable. * Leave the timeout=0 handling unchanged Honouring an explicit timeout=0 makes the gRPC exporter set a deadline that has already passed, so every export fails with DEADLINE_EXCEEDED. Declarative config passes timeout=0 for "no limit", so that needs its own change. Keep the existing `timeout or ...` fallback here. --------- Co-authored-by: Lukas Hering <40302054+herin049@users.noreply.github.com>

…ar (open-telemetry#5705) * fix(prometheus): tolerate invalid OTEL_EXPORTER_PROMETHEUS_PORT env var _AutoPrometheusMetricReader parsed OTEL_EXPORTER_PROMETHEUS_PORT with a bare int() in __init__, so a non-integer value (e.g. "9464abc") or an empty string raised ValueError while building the auto-configured reader and took opentelemetry-instrument/SDK startup down. This is the same class of startup crash already fixed for the OTLP exporters (HTTP _resolve_timeout in open-telemetry#5389, gRPC _timeout_from_env in open-telemetry#5448) and the Zipkin exporters (open-telemetry#5704). Add a private _port_from_env() that skips unset/empty values silently, logs a warning for non-integer values, and falls back to the 9464 default. Explicit configuration is unaffected (the reader's auto server only reads the env var). Assisted-by: Doubao * changelog: add fragment for PR open-telemetry#5705 * test(prometheus): ruff-format the new entrypoint timeout tests The `misc / precommit` job failed because the two added test signatures were split across lines while ruff (v0.16.0, line-length 120) keeps them on one line. Run `ruff format` so `pre-commit run ruff-format` is clean.

herin049 added 7 commits July 3, 2026 22:33

opentelemetry-exporter-otlp-proto-http: refactor to use shared opente…

55e3090

…lemetry-exporter-otlp-common and opentelemetry-exporter-http-transport packages

reformat files

c002458

minor tweaks

ab0923a

update function names

25afb8b

update tests

4721aad

update tests

f3baa3f

fix failing docker tests

10c675a

herin049 added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Jul 6, 2026

paramaterize exponential bucket boundaries test

bb08047

herin049 marked this pull request as ready for review July 6, 2026 02:42

herin049 requested a review from a team as a code owner July 6, 2026 02:42

herin049 requested a review from Copilot July 6, 2026 02:42

otelbot-python Bot added this to Python PR digest Jul 6, 2026

Copilot started reviewing on behalf of herin049 July 6, 2026 02:43

View session

herin049 mentioned this pull request Jul 6, 2026

opentelemetry-exporter-otlp-proto-http: Update exporter to use new HTTP transport package #5219

Closed

6 of 10 tasks

Copilot AI reviewed Jul 6, 2026

View reviewed changes

Potential fix for pull request finding

a8fe28a

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

lzchen reviewed Jul 9, 2026

View reviewed changes

Comment thread ...etry-exporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/_common/__init__.py

lzchen reviewed Jul 9, 2026

View reviewed changes

Comment thread ...orter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/metric_exporter/__init__.py

herin049 added 3 commits July 14, 2026 21:43

remove ability to pass cert file as bool

cff0b6e

merge main into branch

66337fd

update Docker test to include all transport implementations

8d3a392

herin049 requested a review from lzchen July 15, 2026 02:02

herin049 and others added 6 commits July 14, 2026 22:17

fix metrics overcount

bc5a3cd

add more informative error message when requests import fails

22fcff5

Merge branch 'main' into feat/refactor-otlp-http

9bacca4

fix opentelemetry test utils requirements

f3f7d74

fix pre-commit errors

0c39c1d

merge main into branch

6e05cc9

herin049 mentioned this pull request Jul 20, 2026

Remove duplicate session header update in OTLP HTTP exporters #5442

Closed

4 of 6 tasks

github-project-automation Bot moved this to Approved PRs in Python PR digest Aug 6, 2026

herin049 added 2 commits August 10, 2026 20:06

fix merge conflicts

c5d143e

fix tests

49401ff

aabmass added this pull request to the merge queue Aug 11, 2026

aabmass moved this from Approved PRs to Ready for merge in Python PR digest Aug 11, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 11, 2026

aabmass added this pull request to the merge queue Aug 12, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 12, 2026

aabmass added this pull request to the merge queue Aug 12, 2026

Merged via the queue into open-telemetry:main with commit 89cc68b Aug 12, 2026
579 checks passed

github-project-automation Bot moved this from Ready for merge to Done in Python PR digest Aug 12, 2026

Eason09053360 mentioned this pull request Aug 26, 2026

opentelemetry-exporter-otlp-proto-grpc: tolerate invalid timeout env vars #5448

Merged

5 tasks done

ocelotl mentioned this pull request Sep 9, 2026

oss_13_http_exporter_retry_after_backoff_cap ocelotl/opentelemetry-python#18

Closed

feiiiiii5 mentioned this pull request Sep 26, 2026

RhesisClient.from_environment() fails with opentelemetry-exporter-otlp-proto-http 1.45.0 rhesis-ai/rhesis#2832

Closed

3 tasks

This was referenced Sep 28, 2026

fix(otel): fix register() crash with opentelemetry-exporter-otlp-proto-http 1.45 Arize-ai/phoenix#16549

Merged

[BUG]: arize-phoenix-otel v0.17.1 does not work with opentelemetry-sdk>=1.45.0 Arize-ai/phoenix#16547

Closed

This was referenced Sep 28, 2026

fix(zipkin): tolerate invalid OTEL_EXPORTER_ZIPKIN_TIMEOUT env var #5704

Open

fix(prometheus): tolerate invalid OTEL_EXPORTER_PROMETHEUS_PORT env var #5705

Merged

This was referenced Sep 29, 2026

🐛 Bug Report: traceloop-sdk imports requests and httpx without declaring them traceloop/openllmetry#4526

Closed

[M4] main 깨짐의 원인 커밋 자동 bisect RosieOh/otel-canary#11

Open

alundma1 mentioned this pull request Sep 29, 2026

opentelemetry-exporter-otlp-proto-http: 1.45.0 ignores HTTPS_PROXY (default urllib3 transport) #5710

Closed

mikeldking mentioned this pull request Sep 30, 2026

docs: Weekly docs gap audit — 2026-09-30 Arize-ai/phoenix#16638

Open

yoarajota mentioned this pull request Oct 7, 2026

fix(sdk): authenticate OTLP exporter through its own session for OpenTelemetry 1.45 AgentOps-AI/agentops#1468

Open

Navigation Menu

Repository navigation

opentelemetry-exporter-otlp-proto-http: refactor to use shared opentelemetry-exporter-otlp-common and opentelemetry-exporter-http-transport packages - #5389

opentelemetry-exporter-otlp-proto-http: refactor to use shared opentelemetry-exporter-otlp-common and opentelemetry-exporter-http-transport packages#5389
aabmass merged 22 commits into
open-telemetry:mainfrom
herin049:feat/refactor-otlp-http

herin049 commented Jul 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

herin049 commented Jul 4, 2026

Description

Type of change

How Has This Been Tested?

Does This PR Require a Contrib Repo Change?

Checklist:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants