Skip to content

Improve CI by cancelling stale runs and setting timeouts #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

jomcgi
Copy link
Contributor

@jomcgi jomcgi commented Mar 20, 2025

Description

Reduce runner queue times by cancelling runs if a new commit has been pushed to a PR.
Reasonable timeouts have been set to ensure we fail fast when builds are stuck.

Fixes #4473

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested with CI on this PR

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Reduce runner queue times by cancelling runs if a new
commit has been pushed to a PR.
Reasonable timeouts have been set to ensure we fail fast
when builds are stuck.
@jomcgi jomcgi force-pushed the bug-4473/ci-job-concurrency branch from 07a0d5f to b3de075 Compare March 20, 2025 20:57
@jomcgi
Copy link
Contributor Author

jomcgi commented Mar 20, 2025

@jomcgi jomcgi changed the title [WIP] Improve CI by cancelling stale runs and setting timeouts Improve CI by cancelling stale runs and setting timeouts Mar 20, 2025
@jomcgi jomcgi marked this pull request as ready for review March 20, 2025 21:05
@jomcgi jomcgi requested a review from a team as a code owner March 20, 2025 21:05
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! This looks great. Note for approvers/maintainers: with that we can prevent duplicated CI runs in PRs. I believe any savings in CI would be nice. Also, opentelemetry-collector is implementing this

@xrmx xrmx enabled auto-merge (squash) March 26, 2025 13:22
@xrmx xrmx merged commit db2dd1e into open-telemetry:main Mar 26, 2025
385 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

infra: prevent jobs from running indefinitely
3 participants