bugfix: OpenTracing Shim not converting exceptions to format expected by OpenTelemetry #4184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzchen
reviewed
Sep 9, 2024
| for k, v in key_values.items() | ||
| } | ||
|
|
||
| self._otel_span.add_event( |
There was a problem hiding this comment.
Since add_event uses BoundedAttributes aren't all values already sanitized to conform to the OpenTelemetry AttributeValue definition?
There was a problem hiding this comment.
Indeed, but if we don't have these code, the value will not be reformated to str.
Should I do some change in BoundedAttributes?
There was a problem hiding this comment.
@zhihali do you mean change _clean_attribute to cast everything else to str?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4152
Add a sanitize function to make sure the attribute value is converted to string, which align with attributes definition.
Add the warning at logs to better track the error, make sure it will not be ignored after sanitized.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox -e lint-opentelemetry-opentracing-shimDoes This PR Require a Contrib Repo Change?
Checklist: