Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move benchmarks outside of tests directory #4033

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jul 8, 2024

Fixes #4029

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 8, 2024
@ocelotl ocelotl self-assigned this Jul 8, 2024
@ocelotl ocelotl requested a review from a team July 8, 2024 17:36
@lzchen
Copy link
Contributor

lzchen commented Jul 9, 2024

Can you explain with an example why we want to move these out of tests? The original issue does not provide much context.

@ocelotl
Copy link
Contributor Author

ocelotl commented Jul 10, 2024

Can you explain with an example why we want to move these out of tests? The original issue does not provide much context.

We do not want to run benchmarks in CI. Right now, to achieve that, we now have to install pytest-benchmark for every package that has benchmarks. For those packages that do not have benchmarks, we have to run pytest without --benchmark-skip. For those packages that have benchmarks, we need to run pytest with --benchmark-skip.

We can save ourselves all this trouble by just having the benchmarks in a different folder, so that we can just cleanly run pytest pointing to a folder without benchmarks in CI.

@ocelotl
Copy link
Contributor Author

ocelotl commented Jul 10, 2024

BTW, we already have moved benchmarks to another directory in contrib: open-telemetry/opentelemetry-python-contrib#2670

@ocelotl ocelotl merged commit b3ab961 into open-telemetry:main Jul 10, 2024
269 checks passed
@ocelotl ocelotl deleted the issue_4029 branch July 10, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move benchmark tests outside of tests directory
3 participants