Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding link to docs #312

Merged
merged 3 commits into from
Dec 3, 2019
Merged

Adding link to docs #312

merged 3 commits into from
Dec 3, 2019

Conversation

codeboten
Copy link
Contributor

Fixes #245

Signed-off-by: Alex Boten aboten@lightstep.com

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codecov-io
Copy link

codecov-io commented Nov 29, 2019

Codecov Report

Merging #312 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #312   +/-   ##
=======================================
  Coverage   85.76%   85.76%           
=======================================
  Files          33       33           
  Lines        1609     1609           
  Branches      180      180           
=======================================
  Hits         1380     1380           
  Misses        182      182           
  Partials       47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3bb228...845a8c3. Read the comment docs.

@Oberon00
Copy link
Member

@johananl Is this what you had in mind?

Personally I'd prefer not having shortlinks here.

@codeboten
Copy link
Contributor Author

Happy to change it to the full url, I don't have a strong preference either ways

Alex Boten added 2 commits November 29, 2019 08:20
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
@johananl
Copy link
Contributor

johananl commented Nov 29, 2019

@johananl Is this what you had in mind?

Yup, the current status looks good to me. Thanks @codeboten!

Nit: I would have liked to link to the actual Note: section but I don't think Sphinx allows that. I guess we could put the note under its own heading, or convert the note into a "regular" section? 🤔

Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@c24t c24t merged commit 15991af into open-telemetry:master Dec 3, 2019
codeboten pushed a commit to codeboten/opentelemetry-python that referenced this pull request Dec 4, 2019
@codeboten codeboten deleted the issue-245 branch October 6, 2020 15:34
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
closes open-telemetry#311

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OT shim: Link to documentation in comments about time imprecision
7 participants