-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding link to docs #312
Adding link to docs #312
Conversation
Signed-off-by: Alex Boten <aboten@lightstep.com>
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
=======================================
Coverage 85.76% 85.76%
=======================================
Files 33 33
Lines 1609 1609
Branches 180 180
=======================================
Hits 1380 1380
Misses 182 182
Partials 47 47 Continue to review full report at Codecov.
|
@johananl Is this what you had in mind? Personally I'd prefer not having shortlinks here. |
Happy to change it to the full url, I don't have a strong preference either ways |
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Yup, the current status looks good to me. Thanks @codeboten! Nit: I would have liked to link to the actual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
closes open-telemetry#311 Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Fixes #245
Signed-off-by: Alex Boten aboten@lightstep.com