Add url decode for OTEL_RESOUCE_ATTRIBUTES #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalevr
force-pushed
the
decode-values-from-otel-resource-attributes
branch
from
fa5a016
to
eb5c744
Compare
shalevr
force-pushed
the
decode-values-from-otel-resource-attributes
branch
2 times, most recently
from
579e526
to
e54833a
Compare
shalevr
changed the title
shalevr
force-pushed
the
decode-values-from-otel-resource-attributes
branch
from
e54833a
to
e9c793d
Compare
lzchen
approved these changes
Nov 21, 2022
nemoshlag
reviewed
Nov 27, 2022
…/github.com/shalevr/opentelemetry-python into decode-values-from-otel-resource-attributes * 'decode-values-from-otel-resource-attributes' of https://github.com/shalevr/opentelemetry-python: Avoid generator in _ViewInstrumentMatch.collect() (open-telemetry#3035)
nemoshlag
approved these changes
Nov 28, 2022
srikanthccv
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2847
Type of change
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: