Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force_flush to span exporters #2919

Merged
merged 12 commits into from
Sep 22, 2022

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Sep 2, 2022

Description

This adds force_flush to span exporters to ensure the spec-compliance. Since the exporters don't do any batching on their own they just return true.

Fixes #2872
Fixes #1779

@srikanthccv srikanthccv marked this pull request as ready for review September 8, 2022 19:47
@srikanthccv srikanthccv requested a review from a team September 8, 2022 19:47
@ocelotl ocelotl merged commit c0e8f40 into open-telemetry:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement force_flush for span exporters Exporters must implement ForceFlush
3 participants