Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:: Added --insecure of CLI argument #2696

Merged
merged 21 commits into from
Jul 26, 2022
Merged

feat:: Added --insecure of CLI argument #2696

merged 21 commits into from
Jul 26, 2022

Conversation

tonycody
Copy link
Contributor

Description

CLI added the parameter '--insecure' to support whether or not to communicate securely. The opentElemetry auto instrument cannot use the 'insecure' parameter

Fixes # (issue)

@tonycody tonycody requested a review from a team May 17, 2022 10:46
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 17, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: tonycody / name: xs (8d7e24f)

@tonycody tonycody requested a review from srikanthccv May 18, 2022 00:51
@srikanthccv
Copy link
Member

@tonycody we can get this merged if you can address the minor comment and fix the failures.

@srikanthccv
Copy link
Member

@tonycody ping.

@tonycody
Copy link
Contributor Author

@srikanthccv ping.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 14, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@srikanthccv srikanthccv added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Jul 14, 2022
@srikanthccv
Copy link
Member

@tonycody Add changelog and fix lint. Also some new commits are added with XS user, please make sure to sign CLA with it.

@srikanthccv
Copy link
Member

@tonycody your last four commits didn't have user id and preventing from easycla check to pass #2696 (comment).

@tonycody
Copy link
Contributor Author

@srikanthccv ping

@srikanthccv
Copy link
Member

/easycla

@tonycody
Copy link
Contributor Author

@lzchen @srikanthccv review

@srikanthccv
Copy link
Member

@tonycody fix the lint.

@ocelotl
Copy link
Contributor

ocelotl commented Jul 25, 2022

@tonycody just in case, here is an easy way to fix the lint errors:

Run .tox/lint/bin/black .
Run .tox/lint/bin/isort .

@tonycody
Copy link
Contributor Author

@srikanthccv @lzchen ping.

@srikanthccv srikanthccv merged commit c9222bf into open-telemetry:main Jul 26, 2022
@srikanthccv srikanthccv mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees
No one assigned
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tonycody @srikanthccv @ocelotl @lzchen