[opentelemetry-api] rename Default instruments to NoOp #2616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To remain consistent with NoOpMeterProvider and NoOpMeter, the instruments they produce have been renamed as well.
added 2 commits
April 18, 2022 12:46
ocelotl
approved these changes
Apr 18, 2022
ocelotl
reviewed
Apr 18, 2022
lzchen
approved these changes
Apr 18, 2022
added 2 commits
April 19, 2022 07:48
srikanthccv
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To remain consistent with NoOpMeterProvider and NoOpMeter, the instruments they produce have been renamed as well.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Does This PR Require a Contrib Repo Change?
Checklist: