Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SDK MeterProvider #2401

Merged
merged 4 commits into from
Jan 26, 2022
Merged

Refactor SDK MeterProvider #2401

merged 4 commits into from
Jan 26, 2022

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Jan 22, 2022 •
edited
Loading

Description

Fixes race in shutdown and correctly sets the measurement consumer callback for the MetricReader

Fixes #2331
Fixes #2245
Fixes #2239

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e opentelemetry-sdk

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added

@srikanthccv srikanthccv added Skip Changelog PRs that do not require a CHANGELOG.md entry Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary metrics labels Jan 22, 2022
@srikanthccv srikanthccv marked this pull request as ready for review January 22, 2022 22:49
@srikanthccv srikanthccv requested a review from a team January 22, 2022 22:49
@ocelotl ocelotl mentioned this pull request Jan 24, 2022
Closed
@ocelotl ocelotl enabled auto-merge (squash) January 26, 2022 15:47
@ocelotl ocelotl merged commit d112814 into open-telemetry:main Jan 26, 2022
@srikanthccv srikanthccv deleted the meter-provider-fix branch January 26, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocelotl ocelotl ocelotl approved these changes

@lzchen lzchen lzchen approved these changes

@aabmass aabmass aabmass approved these changes

@codeboten codeboten codeboten approved these changes

Assignees
No one assigned
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary metrics Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
5 participants
@srikanthccv @codeboten @aabmass @ocelotl @lzchen