Include parent span in Jaeger gRPC export #1809
Conversation
plajjan
requested review from
a team,
codeboten and
srikanthccv
and removed request for
a team
|
|
plajjan
force-pushed
the
1808-fix-jaeger-grpc-child-of
branch
from
21fe6a8
to
407d055
Compare
|
Not sure on procedure for writing changelog. I just managed to run the test suite and found a test case. I've updated the data there to align with the new exported data. Please check! |
plajjan
force-pushed
the
1808-fix-jaeger-grpc-child-of
branch
from
407d055
to
6127ad9
Compare
|
You are correct. https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/jaeger.md#parent-id
|
This extracts the parent span and adds it as a CHILD_OF reference in the gRPC export, so that we get the expected hierarchy of spans. Test case is updated to cover this case.
plajjan
force-pushed
the
1808-fix-jaeger-grpc-child-of
branch
from
6127ad9
to
1111e16
Compare
|
I see CI complains about a lint. I'm unable to run the lint suite locally (or I don't understand how - trying to follow instructions in CONTRIBUTING.md but won't work for me). However, I have guesstimated the fix based on the CI output and applied a fix that I have force pushed. I have also added a changelog entry (well, I did before but never commented about it). @codeboten @lonewolf3739 guessing one of you pressed the button to run CI. Plxz to press again :) |
|
CI seems to fail on something unrelated after merge of the main branch to this branch. Can it be rerun / retried? Can I do anything? |
|
Yay, thx for merging. You might want to do a follow up PR to fix the changelog. There are now two Changed sections, or maybe this is fixed during release!? |
|
@plajjan no worries, i'll fix it in the other PR i have opened. |
This extracts the parent span and adds it as a CHILD_OF reference in the gRPC export, so that we get the expected hierarchy of spans. Test case is updated to cover this case.
Description
This extracts the parent span and adds it as a CHILD_OF reference in the
gRPC export, so that we get the expected hierarchy of spans.
Fixes #1808
Type of change
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist:
Documentation has been updated(no docs update for a bug fix)