split otlp exporter #1695
Merged
split otlp exporter #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 15, 2021 16:32
codeboten
requested review from
a team,
ocelotl and
lzchen
and removed request for
a team
lzchen
reviewed
Mar 16, 2021
| OpenTelemetry Collector Exporter | ||
| ================================ | ||
| OpenTelemetry Collector Exporters | ||
| ================================= |
There was a problem hiding this comment.
We should add a comment here that says that this simply pulls in all available opentelemetry otlp exporters.
lzchen
reviewed
Mar 16, 2021
| @@ -172,4 +172,4 @@ class OpenTelemetryDistro(BaseDistro): | |||
| """ | |||
|
|
|||
| def _configure(self, **kwargs): | |||
There was a problem hiding this comment.
Could you make a comment in the distro readme all the components that are being used as default?
There was a problem hiding this comment.
Will do as part of #1606
lzchen
reviewed
Mar 16, 2021
lzchen
reviewed
Mar 16, 2021
lzchen
approved these changes
Mar 17, 2021
|
Is this part of or will it fix the issue? #1604 |
ocelotl
suggested changes
Mar 17, 2021
Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
ocelotl
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following moves the code from the existing OTLP exporter to
opentelemetry-exporter-otlp-proto-grpcand creates a meta package that installs it as its dependencyopentelemetry-exporter-otlpPart of #1604
Type of change
Please delete options that are not relevant.
Does This PR Require a Contrib Repo Change?
Checklist: