Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

span: add is_recording_events #141

Merged
merged 3 commits into from
Sep 18, 2019
Merged

span: add is_recording_events #141

merged 3 commits into from
Sep 18, 2019

Commits on Sep 17, 2019

  1. span: add is_recording_events 

    Add missing is_recording_events() function to span in API and SDK.

The important point of this commit is to implement the check in functions like
add_event, set_attribute and so son.  Currently is_recording_events always
returns true.
    @mauriciovasquezbernal
    mauriciovasquezbernal committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    1a59ff3 View commit details
    Browse the repository at this point in the history

  2. Update opentelemetry-api/src/opentelemetry/trace/__init__.py 

    Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>
    @mauriciovasquezbernal @Oberon00
    mauriciovasquezbernal and Oberon00 authored Sep 17, 2019
    Configuration menu
    Copy the full SHA
    d78b8c1 View commit details
    Browse the repository at this point in the history

  3. handle PR review

    @mauriciovasquezbernal
    mauriciovasquezbernal committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    4d57a94 View commit details
    Browse the repository at this point in the history