Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename HTTPTextFormat to TextMapPropagator #1085

Merged
merged 4 commits into from
Sep 9, 2020
Merged

Rename HTTPTextFormat to TextMapPropagator #1085

merged 4 commits into from
Sep 9, 2020

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Sep 9, 2020 •
edited
Loading

Description

As per spec, this change renames the HTTPTextFormat to TextFormatPropagator. Updated the file names accordingly.

Fixes #1083

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Unit tests

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been updated
  • Documentation has been updated

Rename HTTPTextFormat to TextMapPropagator
ba810dd 
As per spec, this change renames the HTTPTextFormat to TextFormatPropagator. Updated the file names accordingly.
@codeboten codeboten requested a review from a team September 9, 2020 02:50
lzchen
lzchen requested changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG for the api package? I believe methods like propagators.get_global_httptextformat are user facing.

@codeboten
Copy link
Contributor Author

CHANGELOG for the api package? I believe methods like propagators.get_global_httptextformat are user facing.

Thanks for the reminder @lzchen!

@codeboten codeboten added the release:required-for-ga To be resolved before GA release label Sep 9, 2020
@aabmass aabmass mentioned this pull request Sep 9, 2020
Closed
3 tasks
aabmass
aabmass approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzchen lzchen merged commit 21994df into open-telemetry:master Sep 9, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@mayurkale22
chore: guidelines for Pull Requests and general Merge Requirements (o…
83b9cd1 
…pen-telemetry#1085)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@aabmass aabmass aabmass approved these changes

Assignees
No one assigned
Labels
release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename HTTPText to TextMap Propagator
3 participants
@codeboten @aabmass @lzchen