Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpanExporter to not receive span if not sampled #1070

Merged
merged 8 commits into from
Sep 9, 2020
Merged

SpanExporter to not receive span if not sampled #1070

merged 8 commits into from
Sep 9, 2020

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Sep 3, 2020

Updates spanprocessors to not pass on span if sampled flag not set to exporter.

According to the table here https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#sampling

@lzchen lzchen requested a review from a team September 3, 2020 16:17
@lzchen lzchen added release:required-for-ga To be resolved before GA release sdk Affects the SDK package. labels Sep 3, 2020
codeboten
codeboten approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ocelotl
ocelotl suggested changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the SDK test cases is failing, apparently a small delay is needed. Lint needs fixing. Besides that, LGTM!

opentelemetry-sdk/tests/trace/export/test_export.py Show resolved Hide resolved
ocelotl
ocelotl approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, minor comment

opentelemetry-sdk/tests/trace/export/test_export.py Outdated Show resolved Hide resolved
@lzchen lzchen merged commit 4726bbf into open-telemetry:master Sep 9, 2020
@lzchen lzchen deleted the sp branch September 9, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@ocelotl ocelotl ocelotl approved these changes

Assignees
No one assigned
Labels
release:required-for-ga To be resolved before GA release sdk Affects the SDK package.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lzchen @codeboten @ocelotl