Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a standard way to "reset" a Configuration object for testing #634

Closed
ocelotl opened this issue May 1, 2020 · 0 comments · Fixed by #636
Closed

Add a standard way to "reset" a Configuration object for testing #634

ocelotl opened this issue May 1, 2020 · 0 comments · Fixed by #636
Assignees
@ocelotl
Labels
enhancement New feature or request tests

Comments

@ocelotl
Copy link
Contributor

ocelotl commented May 1, 2020 •
edited
Loading

It is a common occurrence in tests that the global Configuration object needs to be "reset" between tests. This means that its attributes need to be set back to their original values. Since the Configuration object is immutable by design, some additional, non-production available mechanism is needed to perform this action.

The need for this feature was mentioned in a conversation in #630.
@ocelotl ocelotl self-assigned this May 1, 2020
@ocelotl ocelotl added enhancement New feature or request tests labels May 1, 2020
@ocelotl ocelotl mentioned this issue May 1, 2020
Merged
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@cthulhu-bot @mayurkale22
chore: rename Metric Handle to Bound Instrument (open-telemetry#634) (o…
6f0084f 
…pen-telemetry#638)

* chore: fix renames in metrics test

* chore: fix formatting

* chore: rename BaseInstrument to BaseBoundInstrument

Co-authored-by: Mayur Kale <mayurkale@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
enhancement New feature or request tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add reset for configuration testing ocelotl/opentelemetry-python
1 participant
@ocelotl