Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename MultiSpanProcessor to SynchronousMultiSpanProcessor #622

Closed
toumorokoshi opened this issue Apr 28, 2020 · 1 comment
Closed

rename MultiSpanProcessor to SynchronousMultiSpanProcessor #622

toumorokoshi opened this issue Apr 28, 2020 · 1 comment

Comments

@toumorokoshi
Copy link
Member

There's multiple different ways to author a multispanprocessor, with regards to the behavior of teeing to multiple downstream ones:

  1. synchronously, doing it one at a time
  2. concurrently, doing one or more in a threadpool or other concurrent executor.

I think it's probably good to start clarifying that early, so that consumes can choose which one works for their purposes. To that end, we should rename MultiSpanProcessor to SynchronousMultiSpanProcessor.
@toumorokoshi toumorokoshi mentioned this issue Apr 28, 2020
Merged
@codeboten
Copy link
Contributor

Looks like this was addressed in #594

srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@vmarchaud @mayurkale22
feat: port mongodb-core plugin to mongodb open-telemetry#622 (open-te…
53c40c1 
…lemetry#652)

* feat: port mongodb-core plugin to mongodb open-telemetry#622

* chore: address PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codeboten @toumorokoshi