Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We are running benchmark tests in CI #4018

Closed
ocelotl opened this issue Jul 3, 2024 · 0 comments · Fixed by #4019
Closed

We are running benchmark tests in CI #4018

ocelotl opened this issue Jul 3, 2024 · 0 comments · Fixed by #4019
Assignees
Labels
bug Something isn't working

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Jul 3, 2024

Describe your environment

OS: (e.g, Ubuntu)
Python version: (e.g., Python 3.8.10)
SDK version: (e.g., 1.25.0)
API version: (e.g., 1.25.0)

What happened?

We are running benchmark tests in CI

Steps to Reproduce

Run CI

Expected Result

No benchmark tests being run

Actual Result

Benchmark tests are being run

Additional context

We already have a separate workflow for benchmark tests, we should not run them in CI again. Also, it makes no sense to run them in CI unless these tests can fail in a useful manner, for example if they detect a drop in performance, right now they are not configured to do so.

Would you like to implement a fix?

None

@ocelotl ocelotl added the bug Something isn't working label Jul 3, 2024
@ocelotl ocelotl self-assigned this Jul 3, 2024
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 3, 2024
@ocelotl ocelotl closed this as completed in 3836da8 Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant