Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test cases are executed twice #273

Closed
mauriciovasquezbernal opened this issue Nov 7, 2019 · 4 comments
Closed

test cases are executed twice #273

mauriciovasquezbernal opened this issue Nov 7, 2019 · 4 comments
Assignees
@phalecs
Labels
build & infra Issues related to build & infrastructure. good first issue Good first issue help wanted

Comments

@mauriciovasquezbernal
Copy link
Member

After #128 the test cases are executed twice, once when pytest --cov is run for the coverage targets and another one for the test targets itself.

See https://github.com/open-telemetry/opentelemetry-python/pull/128/files#r338632639.
@c24t c24t added the build & infra Issues related to build & infrastructure. label Dec 5, 2019
@toumorokoshi toumorokoshi added the good first issue Good first issue label Dec 26, 2019
@phalecs
Copy link

phalecs commented Jan 14, 2020

Hi @mauriciovasquezbernal can this be assigned to me?

@lzchen
Copy link
Contributor

lzchen commented Feb 7, 2020

Also just to add, the tests are literally being run twice in tox.
https://github.com/open-telemetry/opentelemetry-python/blob/master/tox.ini#L5-L8

@Oberon00
Copy link
Member

Oberon00 commented Feb 14, 2020 •
edited
Loading

If we don't care about testing setup.py files, we could simply run all tests in a single environment. We could also configure travis to run a "quick check" first, i.e. lint + test everything in the same environment with only a single Python version and then only if that succeeded test+coverage for each package with multiple python versions separately.

@codeboten
Copy link
Contributor

Closing this issue for now, it's not ideal but it's not getting in our way.

srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@OlivierAlbertini
fix(http-plugin): ensure exceptions are handled (open-telemetry#273)
ce2bc95 
* fix(http-plugin): ensure exceptions are handled

refactor(test): remove unnecessary code
add tests
closes open-telemetry#222

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phalecs phalecs

Labels
build & infra Issues related to build & infrastructure. good first issue Good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@codeboten @toumorokoshi @Oberon00 @phalecs @lzchen @mauriciovasquezbernal @c24t