Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that API tracer returns the right value types #142

Closed
Oberon00 opened this issue Sep 17, 2019 · 3 comments · Fixed by #307
Closed

Ensure that API tracer returns the right value types #142

Oberon00 opened this issue Sep 17, 2019 · 3 comments · Fixed by #307
Assignees
@codeboten
Labels
api Affects the API package. bug Something isn't working tracing
Milestone
Alpha v0.3

Comments

@Oberon00
Copy link
Member

See https://github.com/open-telemetry/opentelemetry-python/pull/141/files#r325107543.

Also check mypy configuration to see why this is missed.
@Oberon00 Oberon00 added the bug Something isn't working label Sep 17, 2019
@Oberon00 Oberon00 mentioned this issue Sep 17, 2019
Merged
@mauriciovasquezbernal
Copy link
Member

I found out that mypy doesn't comply about a missing return statement when the function is empty: http://mypy-lang.blogspot.com/2016/11/mypy-046-released.html, not sure if there is a way to enable that, probably not.

@Oberon00 Oberon00 mentioned this issue Sep 25, 2019
Closed
@c24t c24t added this to the Alpha v0.2 milestone Oct 11, 2019
@Oberon00 Oberon00 added api Affects the API package. tracing labels Oct 28, 2019
@c24t c24t modified the milestones: Alpha v0.2, Alpha v0.3 Oct 31, 2019
@c24t
Copy link
Member

c24t commented Oct 31, 2019

We need unit tests that have well-defined -- and different! -- behavior in the case that only the API is loaded and in the case that the SDK is loaded. This could look like the example app.

See also #166. If the API ever returns instances of "interface" classes we are guaranteed to crash. One argument for using ABCs.

@codeboten codeboten self-assigned this Nov 26, 2019
@codeboten codeboten mentioned this issue Nov 27, 2019
Merged
@codeboten
Copy link
Contributor

There's an open issue in mypy to handle empty functions with None returns python/mypy#2350

@c24t c24t closed this as completed in #307 Dec 6, 2019
c24t pushed a commit that referenced this issue Dec 6, 2019
@c24t
Ensure the API returns right value types (#307)
cfecca1 
Fixes #142

Enabling --strict mode for mypy. Added a test in the sdk and the same test in
the api to test the different behaviours between the Tracer, Span and Metric
classes.
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@mayurkale22
chore: update dependency @types/node (open-telemetry#142)
d332c75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
api Affects the API package. bug Something isn't working tracing
Projects
None yet
Milestone
Alpha v0.3
Development

Successfully merging a pull request may close this issue.

Ensure the API returns right value types codeboten/opentelemetry-python
4 participants
@codeboten @Oberon00 @mauriciovasquezbernal @c24t