Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics SDK: The MetricRecord should have access to the resource #1208

Closed
codeboten opened this issue Oct 6, 2020 · 0 comments · Fixed by #1209
Closed

Metrics SDK: The MetricRecord should have access to the resource #1208

codeboten opened this issue Oct 6, 2020 · 0 comments · Fixed by #1209
Assignees
@codeboten
Labels
metrics

Comments

@codeboten
Copy link
Contributor

As per the metrics spec:

ExportRecord: consists of Instrument, Label Set, Resource, Timestamp(s), and Aggregation

Not having the resource in the export record currently causes an issue retrieving resource information in the OTLP exporter.

More information:
https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/metrics/sdk.md#sdk-terminology
@codeboten codeboten self-assigned this Oct 6, 2020
@codeboten codeboten mentioned this issue Oct 6, 2020
Merged
8 tasks
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@mayurkale22
chore: 0.9.0 release proposal (open-telemetry#1208)
904245f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding Resource to MetricRecord codeboten/opentelemetry-python
1 participant
@codeboten