Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Falcon instrumentation compatible with Falcon >=3 #607

Merged
merged 12 commits into from
Aug 24, 2021
Merged

Make Falcon instrumentation compatible with Falcon >=3 #607

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d69fe14
Make Falcon instrumentation compatible with Falcon >=3
adriangb Jul 27, 2021
79d7d7e
Merge branch 'main' into patch-1
owais Jul 31, 2021
3609d8e
Update package.py
adriangb Jul 31, 2021
96cabae
Update CHANGELOG.md
adriangb Jul 31, 2021
73b5ff9
update tox.ini
adriangb Aug 2, 2021
b580ab0
revert changes to tox.ini to test failures
adriangb Aug 2, 2021
c76cd5a
Merge branch 'main' into patch-1
adriangb Aug 2, 2021
aa5d256
Update package.py
adriangb Aug 3, 2021
4bead81
Merge branch 'main' into patch-1
owais Aug 19, 2021
3675fff
Merge branch 'main' into patch-1
adriangb Aug 23, 2021
49a642c
Merge branch 'main' into patch-1
owais Aug 24, 2021
140a221
Merge branch 'main' into patch-1
owais Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#595](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/595))

### Changed
- `opentelemetry-instrumentation-falcon` added support for Falcon 3.
([#607](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/607))
- `opentelemetry-instrumentation-tornado` properly instrument work done in tornado on_finish method.
([#499](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/499))
- `opentelemetry-instrumentation` Fixed cases where trying to use an instrumentation package without the
Expand Down
2 changes: 1 addition & 1 deletion ...opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def response_hook(span, req, resp):

_excluded_urls = get_excluded_urls("FALCON")
_traced_request_attrs = get_traced_request_attrs("FALCON")
_response_propagation_setter = FuncSetter(falcon.api.Response.append_header)
_response_propagation_setter = FuncSetter(falcon.Response.append_header)


class FalconInstrumentor(BaseInstrumentor):
Expand Down