Skip to content

Conversation

@DylanRussell
Copy link
Contributor

Description

Add a log for when fsspec cannot be imported. Right now it fails silently and is easy to miss.

Fixes # (issue)

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • [ x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ x] This change requires a documentation update

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • [ x] Followed the style guidelines of this project
  • [x ] Changelogs have been updated
  • [x ] Unit tests have been added
  • [x ] Documentation has been updated

@DylanRussell DylanRussell requested a review from a team as a code owner December 16, 2025 20:13
Copy link

@JWinermaSplunk JWinermaSplunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a CHANGELOG entry. I might remove the which does nothing from the exception message, as the NoOpCompletionHook is self-explanatory, but that's just a nitpick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants