feat: add extension point to add custom attributes to generate_content spans in google genai instrumentor.
#3961
+42
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces ability to add additional attributes to
generate_content {model.name}spans to Google GenAI instrumentation.Motivation behind this change is to add (non-semconv)
gcp.vertex.agent.event_idattribute, togenerate_content {model.name}spans, in order to correlate events with spans in google/adk-python.Broader motivation is:
generate_contentand legacycall_llmspans.generate_contentspans and deprecatecall_llmspans.call_llmspans containgcp.vertex.agent.event_idattribute, and we still want to correlate events with spans.Note: Event in ADK is not synonymous with event in OTEL. In ADK, Event == LLM Request/Response or Tool Call/Result, in OTEL IIUC Event == Log.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested using:
opentelemetry-instrumentor-google-genaioff my fork in ADK, and successfully adding custom attributes to target spanDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.