opentelemetry-instrumentation-redis: add default span name for pipeline operations #3941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herin049
force-pushed
the
fix-unnamed-spans-redis
branch
from
a60f1a7 to
b86b687
Compare
emdneto
approved these changes
Nov 17, 2025
Member
emdneto
left a comment
emdneto
left a comment
There was a problem hiding this comment.
Semconv spec says:
If neither {db.operation.name} nor {target} are available, span name SHOULD be {db.system.name}. So I think it's ok.
tammy-baylis-swi
approved these changes
Nov 17, 2025
xrmx
approved these changes
Nov 18, 2025
github-project-automation
bot
moved this from Approved PRs
to Done
in @xrmx's Python PR digest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a default span name of
"redis"for pipeline operations to handle edge cases where the span name cannot be derived or when the pipeline operation consists of no commands.Fixes #3337
Type of change
How Has This Been Tested?
Two test cases for the sync & async clients have been added in this PR verifying that a default span name of
"redis"is given for pipeline operations with no commands. The tests can be ran using:Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.