feat(aws-lambda): support stable http semantic convension #3939
+615
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkarakal
force-pushed
the
aws-lambda/span-attributes-http-stable
branch
2 times, most recently
from
968254c to
666a10c
Compare
herin049
reviewed
Nov 21, 2025
| More info: | ||
| https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html | ||
| """ | ||
| result = {} |
Contributor
There was a problem hiding this comment.
Can we rename this to something more descriptive like span_attributes?
Author
There was a problem hiding this comment.
Updated it and rebased on top of the latest main
pkarakal
force-pushed
the
aws-lambda/span-attributes-http-stable
branch
from
666a10c to
19ec493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the
aws-lambdainstrumentation to respect theOTEL_SEMCONV_STABILITY_OPT_INenvironment variable when dealing with HTTP spans. It stops using the SpanAttributes directly and instead opted to use the http utility methods created and used by other http instrumentations. This however means that theaws-lambdanow also depends on theopentelemetry-util-httppackage.Ref #3475
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.