Skip to content

Make gRPC server side instrumentation check for suppress_instrumentation in context #3928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Make gRPC server side instrumentation check for suppress_instrumentation in context #3928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...tion/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@

from opentelemetry import trace
from opentelemetry.context import attach, detach
from opentelemetry.instrumentation.utils import is_instrumentation_enabled
from opentelemetry.propagate import extract
from opentelemetry.semconv._incubating.attributes.net_attributes import (
NET_PEER_IP,
Expand Down Expand Up @@ -279,7 +280,9 @@ def _start_span(
)

def intercept_service(self, continuation, handler_call_details):
if self._filter is not None and not self._filter(handler_call_details):
if (
self._filter is not None and not self._filter(handler_call_details)
) or not is_instrumentation_enabled():
return continuation(handler_call_details)

def telemetry_wrapper(behavior, request_streaming, response_streaming):
Expand Down