Skip to content

Attempt fix for issue #2357 "Failed to detach context" exception for grpc instrumentation #3893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

Attempt fix for issue #2357 "Failed to detach context" exception for grpc instrumentation #3893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion ...tion/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,17 @@ def _intercept_server_stream(
else:
mutable_metadata = OrderedDict(metadata)

with self._start_span(client_info.full_method) as span:
# Manually manage span lifecycle to avoid context issues with generators
span = self._tracer.start_span(
name=client_info.full_method,
kind=trace.SpanKind.CLIENT,
attributes={
SpanAttributes.RPC_SYSTEM: "grpc",
SpanAttributes.RPC_GRPC_STATUS_CODE: grpc.StatusCode.OK.value[0],
},
)

try:
inject(mutable_metadata, setter=_carrier_setter)
metadata = tuple(mutable_metadata.items())
rpc_info = RpcInfo(
Expand All @@ -218,6 +228,9 @@ def _intercept_server_stream(
span.set_status(Status(StatusCode.ERROR))
span.set_attribute(RPC_GRPC_STATUS_CODE, err.code().value[0])
raise err
finally:
span.end()


def intercept_stream(
self, request_or_iterator, metadata, client_info, invoker
Expand Down