missing capture_parameters in instrumentation psycopg#3676
Merged
xrmx merged 7 commits intoopen-telemetry:mainfrom Oct 10, 2025
Merged
missing capture_parameters in instrumentation psycopg#3676xrmx merged 7 commits intoopen-telemetry:mainfrom
xrmx merged 7 commits intoopen-telemetry:mainfrom
Conversation
xrmx
reviewed
Aug 22, 2025
Contributor
xrmx
left a comment
There was a problem hiding this comment.
LGTM, please add a CHANGELOG entry
xrmx
approved these changes
Aug 22, 2025
b30ad9c to
6eabb29
Compare
Contributor
Author
|
@xrmx added changelog as requested. |
Contributor
|
@StefanoOvus please run |
8f6bd0d to
ec2d85b
Compare
Contributor
Author
@xrmx done |
Contributor
|
There is a typecheck failure but I don't think it's related to changes made in this PR: |
ec2d85b to
b99746f
Compare
b99746f to
78a56d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added missing parameter
capture_parametersfor psycopg instrumentation:populates the
db.statement.parametersattribute in spans.Fixes #3569
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added tests for sync and async connection:
instrumentation/opentelemetry-instrumentation-psycopg/tests/test_psycopg_integration.py::TestPostgresqlIntegration::test_span_params_attributeinstrumentation/opentelemetry-instrumentation-psycopg/tests/test_psycopg_integration.py::TestPostgresqlIntegrationAsync::test_span_params_attributeTested in a small script with Python 3.13.3 + jaegertracing/jaeger:2.6.0 docker image (OTLP/gRPC protocol).
tox -e py313-test-instrumentation-psycopgtox -e spellchecktox -e lint-instrumentation-psycopgDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.