Skip to content

Rename InMemoryLogExporter to InMemoryLogRecordExporter #3589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hectorhdzg
Copy link
Member

@hectorhdzg hectorhdzg commented Jun 19, 2025

Description

Rename the following classes to maintain consistency with specs and other languages implementations, only used in tests for this repo.
InMemoryLogExporter to InMemoryLogRecordExporter

Does This PR Require a Core Repo Change?

@hectorhdzg
Copy link
Member Author

I removed alias and reverted to original changes; this is not blocking SDK side rename PR anymore so this can be merged when SDK is released, let me know if there is any other feedback.

@xrmx
Copy link
Contributor

xrmx commented Jul 2, 2025

I removed alias and reverted to original changes; this is not blocking SDK side rename PR anymore so this can be merged when SDK is released, let me know if there is any other feedback.

While this may be fine for CI, for the genai instrumentations that are not tied to a single opentelemetry version there's no guarantee they are running against latest sdk so we need to handle both or bump the baseline.

From google-genai instrumentation pyproject.toml:

  "opentelemetry-api >=1.31.1, <2",
  "opentelemetry-instrumentation >=0.52b1, <2",
  "opentelemetry-semantic-conventions >=0.52b1, <2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants