DB-API instrument_connection accepts optional connect_module#3027
Merged
aabmass merged 6 commits intoopen-telemetry:mainfrom Nov 20, 2024
Merged
Conversation
10 tasks
codefromthecrypt
approved these changes
Nov 20, 2024
Contributor
codefromthecrypt
left a comment
codefromthecrypt
left a comment
There was a problem hiding this comment.
Thanks, I suppose testing here was thought about but considered too much code for what it is covering?
aabmass
approved these changes
Nov 20, 2024
Member
@tammy-baylis-swi any thoughts on this? I can merge once resolved |
Contributor
Author
Yeah more tests! I added some in 916bf5e. Let me know if any changes/more needed. |
aabmass
approved these changes
Nov 20, 2024
instrumentation/opentelemetry-instrumentation-dbapi/tests/test_dbapi_integration.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-dbapi/tests/test_dbapi_integration.py
Outdated
Show resolved
Hide resolved
aabmass
approved these changes
Nov 20, 2024
tammy-baylis-swi
deleted the
instrument-connection-optional-connect-module
branch
13 tasks
xrmx
pushed a commit
to xrmx/opentelemetry-python-contrib
that referenced
this pull request
Jan 24, 2025
…lemetry#3027) * DbApi instrument_connection accepts optional connect_module * Changelog * Add test * Adjust tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DB-API
instrument_connectionaccepts optionalconnect_module.Should be merged before #2942
Fixes #3028
Relates to #2902
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.