Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing ruff as linter and formatter (basic setup) #2921

Merged
merged 10 commits into from
Oct 23, 2024
Merged

Introducing ruff as linter and formatter (basic setup) #2921

merged 10 commits into from
Oct 23, 2024

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Oct 22, 2024 •
edited
Loading

Description

Same as open-telemetry/opentelemetry-python#4223, but added ruff to eachdist.py utility script as well in lintand format commands.

Closes #2449

@emdneto
add ruff setup
b02d025 
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto
fix pyproject
0affb82 
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto
fix _template dir
d3f4ce9 
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto added build & infra Skip Changelog PRs that do not require a CHANGELOG.md entry labels Oct 22, 2024
@emdneto emdneto requested a review from a team as a code owner October 22, 2024 13:48
@emdneto
add ruff to gen-requirements.txt
6e47d6a 
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto
remove dir arg from ruff check
5f38499 
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto
add all fixes from lint and format
e152966 
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto
run ruff for openai instrumentation
d297444 
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto
add detect-same-package parameter to ruff
d86a452 
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
emdneto
emdneto commented Oct 23, 2024
View reviewed changes
Copy link
Member Author

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual changed files https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2921/files/5f384996d9a0a8d65ea72b14012be29019457fd4

emdneto
emdneto commented Oct 23, 2024
View reviewed changes
pyproject.toml Show resolved Hide resolved
xrmx
xrmx approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@xrmx xrmx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This switches opentelemetry from third to first party but LGTM

@lzchen lzchen merged commit 0adc58b into open-telemetry:main Oct 23, 2024
536 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrmx xrmx xrmx approved these changes

@lzchen lzchen lzchen approved these changes

Assignees

@federicobond federicobond

@NathanielRN NathanielRN

@shalevr shalevr

@nikosokolik nikosokolik

@oxeye-nikolay oxeye-nikolay

Labels
build & infra Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate better tools for linting
8 participants
@emdneto @xrmx @lzchen @federicobond @NathanielRN @shalevr @nikosokolik @oxeye-nikolay