-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional attributes for redis.search methods create_index, search #2635
Open
mpozniak95
wants to merge
24
commits into
open-telemetry:main
Choose a base branch
from
mpozniak95:redis_additional_attributes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 22 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
191ef9d
Add wrappers for redis.search methods create_index, search, aggregate
mpozniak95 15e09d3
Skip creating span for redisearch methods in _traced_execute_command
mpozniak95 4cb2415
Reformatted file
mpozniak95 16d99e0
Add additional functional tests
mpozniak95 c53b08e
Merge remote-tracking branch 'origin/main' into redis_additional_attr…
mpozniak95 fd52a83
Merge branch 'main' into redis_additional_attributes
lzchen 5507098
Change the span kind to client, add db.system attributes to added met…
mpozniak95 da7ae34
Reformat files
mpozniak95 5a1a1d5
Merge branch 'main' into redis_additional_attributes
lzchen 748022a
Reformat files
mpozniak95 adc4263
Merge branch 'open-telemetry:main' into redis_additional_attributes
mpozniak95 59b7c91
Remove aggregate, and skip function, edit attributes in execute command
mpozniak95 7b5bd19
Merge branch 'main' into redis_additional_attributes
lzchen a9e5afc
Fix linter problems
mpozniak95 2ad9768
Merge remote-tracking branch 'origin/main' into redis_additional_attr…
mpozniak95 8c6c75d
Change name to _set_span_attribute_if_value, use constant for _FIELD_…
mpozniak95 23b2736
Remove useless return
mpozniak95 6bf2b22
Merge branch 'main' into redis_additional_attributes
lzchen ae5f1a3
Change docker image to redis-stack for redis docker tests
mpozniak95 87374e4
Merge branch 'main' into redis_additional_attributes
lzchen fb3ba66
Add span.is_recording check before adding additional parameters to spans
mpozniak95 c3fc628
Merge branch 'main' into redis_additional_attributes
lzchen cc52746
Add entry to changelog
mpozniak95 f889861
Merge branch 'main' into redis_additional_attributes
lzchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Can't we include this as part of the above "if"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think no, because one of the additional attributes is based on the response of search method so we need this to be placed after:
response = func(*args, **kwargs)
which as I understand should happen even if span is not recording