Fix missing attributes in RedisCluster spans #2626
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
reviewed
Jun 20, 2024
(cherry picked from commit c1f2cd6)
|
I've added the requested test Have to admit that mocking RedisCluster was a challenge. |
|
@a-cid please take a look at failing docker tests |
|
Fixed |
emdneto
reviewed
Jun 26, 2024
Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
lzchen
reviewed
Aug 14, 2024
| if hasattr(conn, "nodes_manager") and hasattr( | ||
| conn.nodes_manager.default_node, "redis_connection" | ||
| ): | ||
| conn = conn.nodes_manager.default_node.redis_connection |
There was a problem hiding this comment.
Can we not access connection_kwargs directly from the NodeManager or is this a different set of kwargs?
There was a problem hiding this comment.
Apologies for the delay, I've been a bit busy with work.
The call to cleanup_kwargs removes host and port from the kwargs passed to the NodeManager, so we have to get them from the nodes.
lzchen
reviewed
Aug 14, 2024
...tion/opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis/__init__.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies
_set_connection_attributesto handleconnbeing an instance ofredis.cluster.RedisCluster.Fixes #2505
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.