Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instrumentation: revise BaseDistro.load_instrumentor documentation #2530

Merged
merged 4 commits into from
May 28, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented May 20, 2024

Description

This method is called for every entrypoint found by auto instrumentation and so it takes just one entry point.

Refs #2528

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

This is called for every entrypoint found by auto instrumentation and
so it takes just one entry point.

Refs open-telemetry#2528
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 20, 2024
@xrmx xrmx requested a review from a team May 20, 2024 13:32
@lzchen lzchen merged commit 25e429a into open-telemetry:main May 28, 2024
314 checks passed
xhdnoah pushed a commit to xhdnoah/opentelemetry-python-contrib that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants