Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description of active requests counter for Django and aiohttp #2514

Closed
wants to merge 1 commit into from

Conversation

dkliban
Copy link

@dkliban dkliban commented May 10, 2024

fixes: #2513

Copy link

linux-foundation-easycla bot commented May 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dkliban / name: Dennis Kliban (187aec5)

dkliban added a commit to dkliban/pulp-service that referenced this pull request May 10, 2024
dkliban added a commit to dkliban/pulp-service that referenced this pull request May 10, 2024
dkliban added a commit to dkliban/pulp-service that referenced this pull request May 10, 2024
@@ -213,7 +213,7 @@ async def middleware(request, handler):
active_requests_counter = meter.create_up_down_counter(
name=MetricInstruments.HTTP_SERVER_ACTIVE_REQUESTS,
unit="requests",
description="measures the number of concurrent HTTP requests those are currently in flight",
description="measures the number of concurrent HTTP requests that are currently in-flight",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmolkova updated the semantic convention package in open-telemetry/opentelemetry-python#3586 to generate instrument creation factories we could use here

@lmolkova would you recommend updating here to use create_http_server_active_requests()?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, that would be great! if you see any issues/opportunities to improve, lmk, happy to update helpers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkliban could you update the PR to use this function for instrument creation?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll try to do that. i haven't seen it actually used anywhere yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, we are using the instrument creation factories now for the migration to the new semconv. At this point, we didn't include aiohttp-server in the list of instrumentation to migrate to the new semconv, but I think it's important since we can release the package now.

dkliban added a commit to dkliban/pulp-service that referenced this pull request May 10, 2024
dkliban added a commit to dkliban/pulp-service that referenced this pull request May 10, 2024
dkliban added a commit to pulp/pulp-service that referenced this pull request May 10, 2024
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the aiohttp-server is still a valid change, but the Django one is supersede by #2714. @dkliban are you still working on this?

@dkliban
Copy link
Author

dkliban commented Sep 11, 2024

Closing this PR because the change was implemented here #2714

@dkliban dkliban closed this Sep 11, 2024
@dkliban dkliban deleted the 2513 branch September 11, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Django's http_server_active_requests guage has wrong description
4 participants