Commit benchmark results to gh-pages branch #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
requested review from
a team,
owais and
aabmass
and removed request for
a team
NathanielRN
force-pushed
the
link-benchmarks-issue
branch
from
34e0c03
to
59b9cb5
Compare
NathanielRN
changed the title
NathanielRN
force-pushed
the
link-benchmarks-issue
branch
3 times, most recently
from
5973235
to
ef4af96
Compare
|
Tests failing for now because we don't have a |
aabmass
approved these changes
Dec 11, 2020
| @@ -51,7 +51,7 @@ for more detail on available tox commands. | |||
|
|
|||
| ### Benchmarks | |||
|
|
|||
| Performance progression of benchmarks for packages distributed by OpenTelemetry Python can be viewed as a [graph of throughput vs commit history](https://open-telemetry.github.io/opentelemetry-python-contrib/benchmarks/index.html). From this page, you can download a JSON file with the performance results. | |||
| Performance progression of benchmarks for packages distributed by OpenTelemetry Python can be viewed as a [graph of throughput vs commit history](https://opentelemetry-python-contrib.readthedocs.io/en/latest/performance/benchmarks.html). From the linked page, you can download a JSON file with the performance results. | |||
There was a problem hiding this comment.
Comment on the other PR for reference: https://github.com/open-telemetry/opentelemetry-python/pull/1469/files#r541332856
NathanielRN
changed the title
NathanielRN
force-pushed
the
link-benchmarks-issue
branch
2 times, most recently
from
a1cf732
to
106fd76
Compare
NathanielRN
commented
Dec 12, 2020
| Performance Tests - Benchmarks | ||
| ============================== | ||
|
|
||
| Click `here <https://open-telemetry.github.io/opentelemetry-python-contrib/benchmarks/index.html>_` to view the latest performance benchmarks for packages in this repo. |
NathanielRN
force-pushed
the
link-benchmarks-issue
branch
from
106fd76
to
e1608d2
Compare
NathanielRN
force-pushed
the
link-benchmarks-issue
branch
from
e1608d2
to
c0445fd
Compare
codeboten
approved these changes
Dec 14, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A follow up to the Core PR that adds benchmarking tests: open-telemetry/opentelemetry-python#1443
We added an issue in #249 and link the issue in the code here
We also found out that the GitHub action will fetch the branch even if it on that branch which produces an error.
This PR goes back to using
gh-pagesand adds a link in the ReadTheDocs directory to point to the benchmarks graphs which will live on thegh-pagesbranch.This is also a good idea to reduce the noise on the
masterbranch.This will fix the current Contrib Repo Tests.
Type of change
How Has This Been Tested?
See my example repo which uses
gh-pagescorrectly to publish to https://nathanielrn.github.io/github-benchmarks-example/benchmarks/index.htmlDoes This PR Require a Contrib Repo Change?
Checklist: