Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_jinja2.py #2491

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

rama280290
Copy link
Contributor

Cross-site scripting (XSS) attacks can occur if untrusted input is not escaped. This applies to templates as well as code. The jinja2 templates may be vulnerable to XSS if the environment has autoescape set to False. Unfortunately, jinja2 sets autoescape to False by default. Explicitly setting autoescape to True when creating an Environment object will prevent this.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Copy link

linux-foundation-easycla bot commented May 3, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@rama280290
Copy link
Contributor Author

rama280290 commented May 29, 2024

@ocelotl Kindly review please

@ocelotl ocelotl removed their assignment Sep 3, 2024
@ocelotl
Copy link
Contributor

ocelotl commented Sep 3, 2024

Please allow maintainers to edit your PR or it will be very hard to merge.

@rama280290
Copy link
Contributor Author

How to allow maintainers to edit this PR?

@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 4, 2024
@xrmx
Copy link
Contributor

xrmx commented Sep 4, 2024

@rama280290 please update the branch

@rama280290
Copy link
Contributor Author

Updated the branch

@xrmx xrmx enabled auto-merge (squash) September 4, 2024 11:55
@xrmx
Copy link
Contributor

xrmx commented Sep 4, 2024

@rama280290 If you could rebase it once more, I've enable auto merge to get this merged. Thanks!

Cross-site scripting (XSS) attacks can occur if untrusted input is not escaped. This applies to templates as well as code. The jinja2 templates may be vulnerable to XSS if the environment has autoescape set to False. Unfortunately, jinja2 sets autoescape to False by default. Explicitly setting autoescape to True when creating an Environment object will prevent this.

Signed-off-by: Rajendran, Ramasubramanian <Ramasubramanian.Rajendran@fmr.com>
auto-merge was automatically disabled September 4, 2024 12:03

Head branch was pushed to by a user without write access

@xrmx xrmx enabled auto-merge (squash) September 4, 2024 12:19
@xrmx xrmx merged commit 6c5730f into open-telemetry:main Sep 4, 2024
521 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants