-
Notifications
You must be signed in to change notification settings - Fork 739
issue 1918: Ensure string values for span status and attribute values #2010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cmpilato
wants to merge
2
commits into
open-telemetry:main
Choose a base branch
from
digitalai-opensource:issue_1918_invalid_attribute_type_fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
issue 1918: Ensure string values for span status and attribute values #2010
cmpilato
wants to merge
2
commits into
open-telemetry:main
from
digitalai-opensource:issue_1918_invalid_attribute_type_fixes
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cmpilato could you please rebase this? |
75fafec
to
fb71a1c
Compare
@xrmx Rebased as requested. |
xrmx
reviewed
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would be nice to add tests for checking that the code now works where previously it failed. Also would be nice to have a changelog entry.
5948f23
to
a8fb179
Compare
smoke
added a commit
to smoke/opentelemetry-python-contrib
that referenced
this pull request
Jul 2, 2025
smoke
added a commit
to smoke/opentelemetry-python-contrib
that referenced
this pull request
Jul 2, 2025
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This aims to fix two cases where data types were deemed invalid, resulting in telemetry not being transmitted to our collector. Specifically:
SpanAttributes.DB_MONGODB_COLLECTION
attribute unless the collection is already a string value.str()
-ify the event failure detailsFixes #1918
Type of change
How Has This Been Tested?
So far, only adhoc testing has been done. Without these changes, we fail to receive telemetry data and see these logged warnings:
With the changes, the warnings are gone and telemetry data flows as expected. We are using pymongo 4.5.0.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.