Instrumentation for AIOKafka #1957
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@awtkns Any update on when can this be merged? |
woile
reviewed
Nov 7, 2023
| AIOKafkaProducer, "send", _wrap_send(tracer, produce_hook) | ||
| ) | ||
| wrap_function_wrapper( | ||
| AIOKafkaConsumer, |
There was a problem hiding this comment.
Should getone and getmany be patched as well?
|
Hi! Is there any updates on this? |
woile
reviewed
Nov 29, 2023
|
|
||
|
|
||
| def _wrap_send(tracer: Tracer, produce_hook: ProduceHookT) -> Callable: | ||
| def _traced_send(func, instance: AIOKafkaProducer, args, kwargs): |
woile
reviewed
Nov 30, 2023
| SpanAttributes.MESSAGING_DESTINATION: topic, | ||
| SpanAttributes.MESSAGING_URL: json.dumps(bootstrap_servers), | ||
| SpanAttributes.MESSAGING_DESTINATION_KIND: "topic", | ||
| SpanAttributes.MESSAGING_KAFKA_CLIENT_ID: client_id, |
There was a problem hiding this comment.
This should be SpanAttributes.MESSAGING_CLIENT_ID as MESSAGING_KAFKA_CLIENT_ID has been deprecated
woile
reviewed
Nov 30, 2023
| _get_span_name, | ||
| _kafka_getter, | ||
| _kafka_setter, | ||
| _wrap_next, |
woile
reviewed
Nov 30, 2023
|
|
||
| from opentelemetry.instrumentation.aiokafka.utils import ( | ||
| KafkaPropertiesExtractor, | ||
| _create_consumer_span, |
woile
reviewed
Nov 30, 2023
| partition = KafkaPropertiesExtractor.extract_send_partition(args, kwargs) | ||
| client_id = KafkaPropertiesExtractor.extract_client_id(instance.client) | ||
|
|
||
| span_name = _get_span_name("publish", topic) |
There was a problem hiding this comment.
I would use send here. As test_utils is using also send and it would be align with python-kafka
dimastbk
reviewed
Dec 6, 2023
|
|
||
| def _uninstrument(self, **kwargs): | ||
| unwrap(AIOKafkaProducer, "send") | ||
| unwrap(AIOKafkaConsumer, "__next__") |
There was a problem hiding this comment.
Suggested change
| unwrap(AIOKafkaConsumer, "__next__") | |
| unwrap(AIOKafkaConsumer, "__anext__") |
6 tasks
|
@awtkns Any update on when can this be merged? |
|
Hi @awtkns, any news on this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.