Feat: Use the lambda runtime as parent context through an opt-in flag #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a previous PR open-telemetry#1657 the lambda behaviour was changed so that it extracs the context from the headers of the lambda event instead of from the lambda runtime, using the _X_AMZN_TRACE_ID env var. This behaviour is undesireble as it is a breaking change to existing users. This PR will add the previous behaviour through an opt-in flag so that users can be gracefully migrated or these two "modes" of operation can exist without conflict. Signed-off-by: Raphael Silva <rapphil@gmail.com>
Signed-off-by: Raphael Silva <rapphil@gmail.com>
tylerbenson
reviewed
Aug 15, 2023
| @@ -107,6 +107,7 @@ def custom_event_context_extractor(lambda_event): | |||
| OTEL_INSTRUMENTATION_AWS_LAMBDA_FLUSH_TIMEOUT = ( | |||
| "OTEL_INSTRUMENTATION_AWS_LAMBDA_FLUSH_TIMEOUT" | |||
| ) | |||
| OTEL_LAMBDA_USE_AWS_CONTEXT_PROPAGATION = "OTEL_LAMBDA_USE_AWS_CONTEXT_PROPAGATION" | |||
There was a problem hiding this comment.
I think this config name is misleading. Per open-telemetry/opentelemetry-specification#3212, x-ray propagation should often be used. The issue at hand is specific to the environment variable.
|
placing this on hold until we decide what the defaults should be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a previous PR #1657 the lambda behaviour was changed so that it extracs the context from the headers of the lambda event instead of from the lambda runtime, using the _X_AMZN_TRACE_ID env var.
This behaviour is undesireble as it is a breaking change to existing users.
This PR will add the previous behaviour through an opt-in flag so that users can be gracefully migrated or these two "modes" of operation can exist without conflict.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.