Fix 1455: [test-only] Protect metric data_points from raw next() calls #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ocelotl
approved these changes
Nov 18, 2022
|
Looks like #1460 is going to take care of these test failures. |
- Ensure we wrap data_points so we don't assume `Iterator` traits
lancetarn
force-pushed
the
1455-tornado-test-futureproof
branch
from
fb924c8
to
5b7ffc7
Compare
lzchen
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IteratortraitsDescription
In the course of resolving open-telemetry/opentelemetry-python#3035 it turned out that these tests were making some assumptions about the
data_pointsproperty that are not supported by the current type annotations (although the implementation happens to).Fixes #1455
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This is a test-only issue for the sake of compatibility.
Does This PR Require a Core Repo Change?
Should be forward-compatible with the related Core PR
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.