Add support for regular expression matching and sanitizing of headers in Flask. #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogersd
commented
Oct 27, 2022
| @@ -16,48 +16,6 @@ Installation | |||
|
|
|||
| pip install opentelemetry-instrumentation-flask | |||
|
|
|||
| Configuration | |||
There was a problem hiding this comment.
This cleanup got missed in ae7a415
srikanthccv
approved these changes
Oct 29, 2022
saartochner-lumigo
pushed a commit
to lumigo-io/opentelemetry-python-contrib
that referenced
this pull request
Nov 13, 2022
… in Flask. (open-telemetry#1413) Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
saartochner-lumigo
pushed a commit
to lumigo-io/opentelemetry-python-contrib
that referenced
this pull request
Nov 13, 2022
… in Flask. (open-telemetry#1413) Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next part of #1184
Description
Add test cases for regular expression matching.
Add test cases for header sanitizing.
Add documentation for regular expression matching and header sanitation.
Various documentation cleanups and standardization.
Fixes #1184
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.